Move uniform_officer to suits_clothes.json, add FANCY tag to it and remove OVERSIZE tag

[AlbertNewton]

Summary

Balance "Made officer_uniform human-sized and fancy"

Purpose of change

Fixes #60019 I made the dress uniform fancy because dress uniforms in reality are usually pretty fancy, and the item description calls it "very stylish", and removed the OVERSIZE flag because it didn't make sense for a dress uniform to be too big for a human to wear. I also moved it to suits_clothes because I couldn't see why it was in suits_protection.

Describe the solution

I added the FANCY flag to the officer_uniform item and removed the OVERSIZE flag, then cut-and-pasted it to suits_clothes.json.

Describe alternatives you've considered

• Making it super fancy instead (not appropriate for service dress, which I assume it represents, rather than some sort of full dress uniform)
• Not moving it to suits_clothes

Testing

Spawned a dress uniform, wore it, verified it was FANCY and not OVERSIZE, it didn't break anything.

Additional context

None

[AlbertNewton]

Does anyone have any idea why the checks failed?

[NetSysFire]

Yes. Known issue: #60026

[descan]

Wouldn't it make more sense to make that a pants, shirt, jacket etc instead of one big jumpsuit?

Perhaps, although this isn't an addition but just a small change to the already existing item. Breaking it up into multiple objects would probably be more suited to a new PR, no? (And/or changing the pockets.)

[Fris0uman]

Yeah it's a bit out of scope but on the ohter hand the FANCY flag is infinite tarpit of adding it and removing it every other month to every cloth, spliting the suit into different part and fixing the pocket would look more like progress

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[kevingranade]

Too ptactical for fancy tag, and I really prefer not to shuffle items around without a conpelling reason.