pytest-postgresql icon indicating copy to clipboard operation
pytest-postgresql copied to clipboard

Refactor executor test for macOS and LC_ALL tests

Open bhelgs opened this issue 1 year ago • 2 comments

Changes made

  1. Adds a test for your recent PR (#965).
  2. refactors the test to remove the skipif for Darwin.

I think my solution is still less than ideal so I left the implementation details underscored (_). Maybe something like builder pattern or PostgreSQLExecutor(**config) would be good.

Testing

  1. I was able to verify your PR #965 does in fact fix the issue the user encounted.

    • before 965 PR: image
    • after 965 PR: image
  2. tested on a mac to verify that the latest code runs.

Chore that needs to be done:

  • [x] Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_number either from issue tracker or the Pull request number

bhelgs avatar Aug 24 '24 22:08 bhelgs

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.83%. Comparing base (22944af) to head (68c0ec9). Report is 230 commits behind head on main.

Files with missing lines Patch % Lines
pytest_postgresql/factories/process.py 85.71% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
+ Coverage   95.26%   95.83%   +0.57%     
==========================================
  Files          13       13              
  Lines         401      432      +31     
==========================================
+ Hits          382      414      +32     
+ Misses         19       18       -1     
Flag Coverage Δ
unittests 95.83% <86.66%> (+0.57%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 27 '24 09:08 codecov-commenter

latest push fixes the lint check. Sorry for missing that. Have a good day!

bhelgs avatar Aug 31 '24 13:08 bhelgs

@bhelgs you can also update the port-for

fizyk avatar Sep 02 '24 15:09 fizyk

@bhelgs you can also update the port-for

Done in latest push.

I know these changes have taken up quite a bit of your time. I just want to say I really appreciate this project and your support.

bhelgs avatar Sep 02 '24 19:09 bhelgs

And I do appreciate Your contributions :)

fizyk avatar Sep 03 '24 09:09 fizyk