citizenlab
citizenlab copied to clipboard
CitizenLabDotCo
Chromatic setup improvements
| Warnings | |
|---|---|
| :warning: | The PR title contains no Jira issue key (case-sensitive) |
| :warning: | The branch name contains no Jira issue key (case-sensitive) |
| Messages | |
|---|---|
| :book: | Changelog provided 🎉 |
| :book: | |
| :book: | Check translation progress |
Generated by :no_entry_sign: dangerJS against b5f84b3f3071d7c88de95933498783fdedcf8049
@IvaKop I guess just skip all changes inside of the app folder, and focus on the other files!
In the end, I had to create two separate configurations: one for the CI build and one for local hot-reload dev mode. The former still uses webpack, the latter vite. I tried using vite for the CI build too but I kept getting an error where node ran out of memory, and I tried almost every solution I could find online (e.g. in this thread), but nothing worked
Did we test everything properly to make sure it's not breaking the current behaviour of our data-fetching?
I don't think it can break anything- if data was ever null before it would have crashed the browser so we would have noticed. But anyway I'm happy to run the e2e tests again just to be sure