citizenlab icon indicating copy to clipboard operation
citizenlab copied to clipboard

Published 20 hours ago • verified publisher icon CitizenLabDotCo

Tan 1062/replace HasPermission component

Open brentguf opened this issue 1 year ago • 1 comments
trafficstars

brentguf avatar Mar 11 '24 11:03 brentguf

Warnings
:warning: The PR title contains no Jira issue key (case-sensitive)
:warning: The branch name contains no Jira issue key (case-sensitive)
Messages
:book: Changelog provided 🎉
:book:

Run the e2e tests
:book: Check translation progress

Generated by :no_entry_sign: dangerJS against 8d8ae08711535b5d41e2d5dcc1efaa162bbfc704

cl-dev-bot avatar Mar 11 '24 11:03 cl-dev-bot

Replace HasPermission + fix bug usePermission for undefined user

notion-workspace[bot] avatar Mar 12 '24 09:03 notion-workspace[bot]

I can't see anything problematic with the code so I will approve. It's nice to see us getting rid of a big chunk of the complexity with our permissions - it's usually better to have one way of doing things. Let's run the e2e tests before merging to make sure we don't have issues.

@IvaKop They passed. I've learned my lesson when tinkering with permissions. :-)

brentguf avatar Mar 13 '24 09:03 brentguf