citizenlab
citizenlab copied to clipboard
CitizenLabDotCo
TAN-4750: Add timeline
![notion-workspace[bot] avatar](https://avatars.githubusercontent.com/in/300037?v=4 "Published by a pub.dev verified publisher"){kind=small}
| Messages | |
|---|---|
| :book: | Changelog provided 🎉 |
| :book: | Notion issue: TAN-4750 |
| :book: | |
| :book: | Check translation progress |
Generated by :no_entry_sign: dangerJS against 215d18e26894692b752f37e2f0487687e0319aff
@luucvanderzee there is still a known bug where sometimes the chart is not correctly centered on the current day on initial render. I'm working on a fix for this but this can already be reviewed.
Sorry for the large amount of critique and requested changes! Anything with timelines and calendars is just super super hard to get right, and developing this stuff without libraries is really not easy. I would say it is normal to take a few weeks.
If stuff like the scrolling is really hard to fix, we could consider releasing it without, because the overview part (which is the main functionality) already works fine and could provide value. But I am afraid that the yankiness would distract and discourage clients from using it in their day to day workflow. We can discuss this on Monday maybe
Not a problem at all, I really appreciate the thorough review! You've raised some great points. Also reminds me to test it out with really small timelines and long text. I agree that the user experience with the scrolling is critical, and we should get it right. I'll dig into the issues now
@luucvanderzee good points 💪 . Feedback has been addressed. Please take another look when you get a moment