terraform-provider-aci icon indicating copy to clipboard operation
terraform-provider-aci copied to clipboard

Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol)

Open gmicol opened this issue 1 year ago • 1 comments

Resolves #1211

gmicol avatar Jun 26 '24 17:06 gmicol

Codecov Report

Attention: Patch coverage is 91.58249% with 100 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (9465913) to head (a60dbbc). Report is 168 commits behind head on master.

Files with missing lines Patch % Lines
...l/provider/resource_aci_netflow_exporter_policy.go 89.34% 49 Missing and 29 partials :warning:
...rovider/data_source_aci_netflow_exporter_policy.go 94.04% 7 Missing and 3 partials :warning:
internal/provider/resource_aci_application_epg.go 88.88% 6 Missing :warning:
...l/provider/resource_aci_endpoint_security_group.go 81.81% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
+ Coverage   85.08%   85.25%   +0.17%     
==========================================
  Files         100      102       +2     
  Lines       36784    37812    +1028     
==========================================
+ Hits        31298    32238     +940     
- Misses       4062     4118      +56     
- Partials     1424     1456      +32     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 26 '24 18:06 codecov-commenter

There are tests failing please also check CI

akinross avatar Aug 27 '24 08:08 akinross

There are still a lot of open comments, are you still working on those? Could you please respond to those?

akinross avatar Aug 30 '24 12:08 akinross