DJ-Native-Swing
DJ-Native-Swing copied to clipboard
Chrriis
Project Mavenization and some enhancements
- Mavenized the project. This allows for standard usage from any IDE supporting maven (i.e. NetBeans, Eclipse, etc).
- Added to the FlashPlayer API a way to enable jQuery in the generated HTML. This allows lots of customization and control from the end user.
- Address some global variables being hidden.
Hi,
First, I apologize for taking so long to answer. I generally have a bit more free time during week-ends which is why I am investigating your changes only now.
I am reviewing the pull request, manually integrating some changes if I decide it is applicable. So here are my comments.
- I cleaned up some typos that you found.
- The code is compiled with Java 5. That means I cannot use @Override annotation for interface method implementations.
- When reviewing, it is very hard to diff properly when you make some code style changes. This means that because of indentation changes or code style I may miss some differences (e.g.: NativeComponentProxyPanel).
- "Change variable to avoid hiding a global variable" is part of code style. I personally don't think hiding global scope is bad provided the people who write the code know what they are doing. Syntax highlighting shows whether scope is respected.
- "Added to the FlashPlayer API a way to enable jQuery in the generated HTML. This allows lots of customization and control from the end user.". Where is that code? I am curious as to which additions you made that may be of interest to the users of the library.
- About Mavenization, I don't use Maven myself, and I don't want to turn the project I use for development to Maven. That does not mean I can't ship POM files. Maybe I could add the POM files but then my problem becomes keeping in sync those files with what I have in the project. Maybe if your POM files were just a match for the current development environment I could just integrate them. For example, I am still on SWT 3.7 for several reasons while your POM file uses SWT 4.2. Note that some users have made Maven variants of the project which they occasionally advertise, but this is for using the library, not really for development (is there a difference? I wonder). An example is: https://sourceforge.net/p/djproject/discussion/671154/thread/255931c8/?limit=25#2734
Cheers, -Christopher
I understand don't worry. I'll revert the changes you don't agree with and downgrade SWT libraries to 3.7 so you can pull. Pom files are a match of the current environment except for the SWT libraries which I'll downgrade. Can you explain the reasons for staying on SWT 3.7? I'm having the focus issue but I'm on that version of SWT. I might downgrade and try.
I'll give you more details on jquery in a bit.
On Sun, Jan 27, 2013 at 7:03 AM, Christopher Deckers < [email protected]> wrote:
Hi,
First, I apologize for taking so long to answer. I generally have a bit more free time during week-ends which is why I am investigating your changes only now.
I am reviewing the pull request, manually integrating some changes if I decide it is applicable. So here are my comments.
I cleaned up some typos that you found. 2.
The code is compiled with Java 5. That means I cannot use @Overridehttps://github.com/Overrideannotation for interface method implementations. 3.
When reviewing, it is very hard to diff properly when you make some code style changes. This means that because of indentation changes or code style I may miss some differences (e.g.: NativeComponentProxyPanel). 4.
"Change variable to avoid hiding a global variable" is part of code style. I personally don't think hiding global scope is bad provided the people who write the code know what they are doing. Syntax highlighting shows whether scope is respected. 5.
"Added to the FlashPlayer API a way to enable jQuery in the generated HTML. This allows lots of customization and control from the end user.". Where is that code? I am curious as to which additions you made that may be of interest to the users of the library. 6.
About Mavenization, I don't use Maven myself, and I don't want to turn the project I use for development to Maven. That does not mean I can't ship POM files. Maybe I could add the POM files but then my problem becomes keeping in sync those files with what I have in the project. Maybe if your POM files were just a match for the current development environment I could just integrate them. For example, I am still on SWT 3.7 for several reasons while your POM file uses SWT 4.2. Note that some users have made Maven variants of the project which they occasionally advertise, but this is for using the library, not really for development (is there a difference? I wonder). An example is:
https://sourceforge.net/p/djproject/discussion/671154/thread/255931c8/?limit=25#2734
Cheers, -Christopher
— Reply to this email directly or view it on GitHubhttps://github.com/Chrriis/DJ-Native-Swing/pull/2#issuecomment-12753813.
To enable jquery just add this script to the generated html:
On Mon, Jan 28, 2013 at 8:44 AM, Javier Ortiz [email protected]:
I understand don't worry. I'll revert the changes you don't agree with and downgrade SWT libraries to 3.7 so you can pull. Pom files are a match of the current environment except for the SWT libraries which I'll downgrade. Can you explain the reasons for staying on SWT 3.7? I'm having the focus issue but I'm on that version of SWT. I might downgrade and try.
I'll give you more details on jquery in a bit.
On Sun, Jan 27, 2013 at 7:03 AM, Christopher Deckers < [email protected]> wrote:
Hi,
First, I apologize for taking so long to answer. I generally have a bit more free time during week-ends which is why I am investigating your changes only now.
I am reviewing the pull request, manually integrating some changes if I decide it is applicable. So here are my comments.
I cleaned up some typos that you found. 2.
The code is compiled with Java 5. That means I cannot use @Overridehttps://github.com/Overrideannotation for interface method implementations. 3.
When reviewing, it is very hard to diff properly when you make some code style changes. This means that because of indentation changes or code style I may miss some differences (e.g.: NativeComponentProxyPanel). 4.
"Change variable to avoid hiding a global variable" is part of code style. I personally don't think hiding global scope is bad provided the people who write the code know what they are doing. Syntax highlighting shows whether scope is respected. 5.
"Added to the FlashPlayer API a way to enable jQuery in the generated HTML. This allows lots of customization and control from the end user.". Where is that code? I am curious as to which additions you made that may be of interest to the users of the library. 6.
About Mavenization, I don't use Maven myself, and I don't want to turn the project I use for development to Maven. That does not mean I can't ship POM files. Maybe I could add the POM files but then my problem becomes keeping in sync those files with what I have in the project. Maybe if your POM files were just a match for the current development environment I could just integrate them. For example, I am still on SWT 3.7 for several reasons while your POM file uses SWT 4.2. Note that some users have made Maven variants of the project which they occasionally advertise, but this is for using the library, not really for development (is there a difference? I wonder). An example is:
https://sourceforge.net/p/djproject/discussion/671154/thread/255931c8/?limit=25#2734
Cheers, -Christopher
— Reply to this email directly or view it on GitHubhttps://github.com/Chrriis/DJ-Native-Swing/pull/2#issuecomment-12753813.
@Chrriis I've found that you still reply questions on the Help forum at sourceforge, is this project "alive"? so to speak. I run the DJNativeSwing-SWTDemo.jar and I liked what I saw.
I'm looking for a replacement to the Google Maps Static API (which is now charged) and I thought that showing an iframe or the Maps website with the address could be a solution.
DJNativeSwing shows the map and allows you to move/zoom. However, it is not possible to interact with the left options panel of Google Maps (for example, it can not be hidden). Also, once you move/zoom the map a Loading... message appears at the bottom and remains there.
Are these issues related to DJNativeSwing or has to do with SWT/Java? (I'm running Java 8 u144)
@IvanRF The project does not evolve, because Swing is less and less used. The problems you mention are probably related to the renderer that SWT is using on your platform. It is possible that some meta tags in the page that you load make a difference, so you have to experiment with such compatibility settings.