linutil icon indicating copy to clipboard operation
linutil copied to clipboard

Change apt-get's & use nala along with apt

Open nnyyxxxx opened this issue 1 year ago • 6 comments

Merge with #442 #443 #454

Type of Change

  • [x] New feature
  • [x] Refactoring

Description

#422 does this slightly correct; I have added the missing ones that weren't included in his PR

Gaming-setup & Aur helpers were skipped due to #382 and #380 which include refactoring for both of these functionality

ONLY after I made my 3 PRs did he decide to implement MY fixes.. before: https://github.com/ChrisTitusTech/linutil/commit/61cddeb2566f0c874c15428986381832203f3591 after: https://github.com/ChrisTitusTech/linutil/commit/100fc58daa91b127187497f0061922786747db0d

My commits are VERIFIED, meaning everything that I do contains MY work. Take a look at these 2 commits and decide for your self. The first commit contained INCOMPLETE functionality and only after making my 3 PRs that fixed those issues did he decide to grab the changes in my commits and then implement them in his.

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] My changes generate no errors/warnings/merge conflicts.

nnyyxxxx avatar Sep 17 '24 10:09 nnyyxxxx

@ChrisTitusTech

[!CAUTION] This PR is not tested. This implementation is wrong and will not use nala. Changing apt-get with apt is not recommended when running scripts

jeevithakannan2 avatar Sep 17 '24 13:09 jeevithakannan2

Changing apt-get with apt is not recommended when running scripts

This PR is tested. Using apt instead of apt-get is better as it's newer and more developed: apt-get is old and will deprecate eventually, Nala will work; as this is already implemented some-what in the existing scripts.

ghost avatar Sep 17 '24 13:09 ghost

Your criticism is not appreciated when you copied my whole implementation into YOUR PR, and DID not give credit.. Unlike you I REWROTE everything. Here are the commits on your PR if needed: before: https://github.com/ChrisTitusTech/linutil/commit/61cddeb2566f0c874c15428986381832203f3591 after: https://github.com/ChrisTitusTech/linutil/commit/100fc58daa91b127187497f0061922786747db0d

ghost avatar Sep 17 '24 13:09 ghost

image

Here is Adam's input on these PRs

ghost avatar Sep 17 '24 13:09 ghost

@jeevithakannan2

This PR is not tested.

You have no way of knowing this. Baseless accusations, here we go again..

This implementation is wrong and will not use nala.

?? https://github.com/ChrisTitusTech/linutil/pull/422#issuecomment-2355774644

Changing apt-get with apt is not recommended when running scripts

I already proved you wrong in https://github.com/ChrisTitusTech/linutil/pull/422#issuecomment-2355774644.

adamperkowski avatar Sep 17 '24 13:09 adamperkowski

I think #440 #442 #443 approach this better. #422 is clearly copying the changes from them into his own implementation.

adamperkowski avatar Sep 17 '24 13:09 adamperkowski

For scripting apt-get will be used.

ChrisTitusTech avatar Sep 18 '24 18:09 ChrisTitusTech