linutil icon indicating copy to clipboard operation
linutil copied to clipboard

Replace remaining echo -e statement

Open nnyyxxxx opened this issue 1 year ago • 14 comments

Type of Change

  • [x] Bug fix

  • Resolves #406

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] My changes generate no errors/warnings/merge conflicts.

nnyyxxxx avatar Sep 16 '24 00:09 nnyyxxxx

haha happens a lot of times :)

guruswarupa avatar Sep 16 '24 01:09 guruswarupa

haha happens a lot of times :)

This one was really obscure, didn't think to look in any of the start scripts; my mistake.

ghost avatar Sep 16 '24 01:09 ghost

Change common script line 37

echo -e "${RED}Failed to install AUR helper.${RC}"

jeevithakannan2 avatar Sep 16 '24 06:09 jeevithakannan2

Change common script line 37

echo -e "${RED}Failed to install AUR helper.${RC}"

No need, #382 does this already.

ghost avatar Sep 16 '24 06:09 ghost

read -s password

Will not work in wifi-control.sh line 139

jeevithakannan2 avatar Sep 16 '24 06:09 jeevithakannan2

use

stty -echo
read password
stty echo

jeevithakannan2 avatar Sep 16 '24 06:09 jeevithakannan2

@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.

ghost avatar Sep 16 '24 06:09 ghost

@jeevithakannan2 Should be fine.

read -s is not posix compliant will not work in debian 11 and 12

jeevithakannan2 avatar Sep 16 '24 06:09 jeevithakannan2

@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.

If you're creating a PR then make sure it does everything what you have described !!

jeevithakannan2 avatar Sep 16 '24 06:09 jeevithakannan2

@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.

If you're creating a PR then make sure it does everything what you have described !!

A different PR would have to be made separate from this for every fixed script. It is 2 AM where I am at and cannot fix that issue ATM.

ghost avatar Sep 16 '24 06:09 ghost

@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.

If you're creating a PR then make sure it does everything what you have described !!

A different PR would have to be made separate from this for every fixed script. It is 2 AM where I am at and cannot fix that issue ATM.

Then you should be putting this PR as draft and finish it later rather than debating with people that are doing their job

jeevithakannan2 avatar Sep 16 '24 06:09 jeevithakannan2

@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.

If you're creating a PR then make sure it does everything what you have described !!

A different PR would have to be made separate from this for every fixed script. It is 2 AM where I am at and cannot fix that issue ATM.

Then you should be putting this PR as draft and finish it later rather than debating with people that are doing their job

Not sure what you mean, I just recommended that this PR should be split up into multiple e.g. for every fix implemented, no need to be rude about it..

ghost avatar Sep 16 '24 06:09 ghost

I'll do this TMR when I have time.

ghost avatar Sep 16 '24 06:09 ghost

I've changed my view on this; I have given the task to two fellow contributors as discussed in the discord server, for now this will just be cleaning up the last echo -e :)

ghost avatar Sep 17 '24 16:09 ghost