linutil
linutil copied to clipboard
Replace remaining echo -e statement
Type of Change
-
[x] Bug fix
-
Resolves #406
Checklist
- [x] My code adheres to the coding and style guidelines of the project.
- [x] I have performed a self-review of my own code.
- [x] My changes generate no errors/warnings/merge conflicts.
haha happens a lot of times :)
haha happens a lot of times :)
This one was really obscure, didn't think to look in any of the start scripts; my mistake.
Change common script line 37
echo -e "${RED}Failed to install AUR helper.${RC}"
Change common script line 37
echo -e "${RED}Failed to install AUR helper.${RC}"
No need, #382 does this already.
read -s password
Will not work in wifi-control.sh line 139
use
stty -echo
read password
stty echo
@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.
@jeevithakannan2 Should be fine.
read -s is not posix compliant will not work in debian 11 and 12
@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.
If you're creating a PR then make sure it does everything what you have described !!
@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.
If you're creating a PR then make sure it does everything what you have described !!
A different PR would have to be made separate from this for every fixed script. It is 2 AM where I am at and cannot fix that issue ATM.
@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.
If you're creating a PR then make sure it does everything what you have described !!
A different PR would have to be made separate from this for every fixed script. It is 2 AM where I am at and cannot fix that issue ATM.
Then you should be putting this PR as draft and finish it later rather than debating with people that are doing their job
@jeevithakannan2 If you want to implement that then make a PR and gloss over the util scripts.
If you're creating a PR then make sure it does everything what you have described !!
A different PR would have to be made separate from this for every fixed script. It is 2 AM where I am at and cannot fix that issue ATM.
Then you should be putting this PR as draft and finish it later rather than debating with people that are doing their job
Not sure what you mean, I just recommended that this PR should be split up into multiple e.g. for every fix implemented, no need to be rude about it..
I'll do this TMR when I have time.
I've changed my view on this; I have given the task to two fellow contributors as discussed in the discord server, for now this will just be cleaning up the last echo -e :)