linutil icon indicating copy to clipboard operation
linutil copied to clipboard

Initial support for flathub management

Open kleidis opened this issue 1 year ago • 10 comments

Pull Request

Title

Initial support for flathub management

Type of Change

  • [x] New feature
  • [ ] Bug fix
  • [x] Documentation Update
  • [ ] Refactoring
  • [ ] Hotfix
  • [ ] Security patch
  • [ ] UI/UX improvement

Description

This PR adds a new folder on Application Setup tab that has 2 items related to flathub

  • Setup flatpak
    • Downloads flatpak package and adds the flathub remote
  • Uninstall flatpak
    • Uninstalls flathub and removes remote

Also updates flathub update on system update script

Testing

I confirm OpneSUSE TW and Ubuntu are working but also did earlier testing on Fedora and Arch which also worked

Impact

Easy setup of flathub remote for new users

Issue related to PR

  • Resolves https://github.com/ChrisTitusTech/linutil/issues/290

Additional Information

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no errors/warnings/merge conflicts.

kleidis avatar Sep 11 '24 15:09 kleidis

@kleidis TOO many bashisms in this; Linutil is supposed to be posix compliant, also duplicate of #339

ghost avatar Sep 11 '24 15:09 ghost

@kleidis TOO many bashisms in this; Linutil is supposed to be posix compliant, also duplicate of #339

Removing the bashisms can be possible, but should I close this in favor of the other PR?

The way he implemented flathub setup, it isn't ideal Edit: Seems he clsoed it

ghost avatar Sep 11 '24 15:09 ghost

@kleidis TOO many bashisms in this; Linutil is supposed to be posix compliant, also duplicate of #339

Removing the bashisms can be possible, but should I close this in favor of the other PR?

The way he implemented flathub setup, it isn't ideal Edit: Seems he clsoed it

You should go over the scripts with the "checkbashisms" package to ward out all of them.

ghost avatar Sep 11 '24 15:09 ghost

Since I might be busy, I'm converting it to a draft

ghost avatar Sep 11 '24 17:09 ghost

Had to remove the download script because removing all bashisms while keeping the TUI proved to be challenging Looks like this needs to be tackled directly with the rust code, which I am not willing to do RN

Not to mention the flathub API completely stopped working today for whatever reason while it was working fine yesterday, so it really doesn't seem like a good way of fetching flathub

ghost avatar Sep 12 '24 16:09 ghost

@nnyyxxxx Mind rechecking?

ghost avatar Sep 12 '24 16:09 ghost

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

ChrisTitusTech avatar Sep 12 '24 18:09 ChrisTitusTech

First

ghost avatar Sep 12 '24 18:09 ghost

All should be good now

ghost avatar Sep 13 '24 12:09 ghost

As discussed on https://github.com/ChrisTitusTech/linutil/pull/362 , uninstall or revert scripts should not be separate entries

Once the revert_tweaks script is in place, i'll re-add the uninstall part of the script back For now, it will be removed

ghost avatar Sep 13 '24 17:09 ghost