lens-csv icon indicating copy to clipboard operation
lens-csv copied to clipboard

Add tests

Open ChrisPenner opened this issue 5 years ago • 2 comments

Things seem to be working, but a few tests would be great 😄

ChrisPenner avatar Oct 02 '20 20:10 ChrisPenner

Sounds great. What are the major priorities? What is the most important to be tested?

IJustDev avatar Oct 02 '20 22:10 IJustDev

Hi @IJustDev ! Thanks for the interest 😄

Most important to test are probably:

  • adjustingOutputHeaders which should let you drop and add headers from a CSV
  • General full-csv transformations; e.g. things like myCsv & csv . rows . _Record @(String, String) %~ swap

Don't worry about testing any combinators from lens itself, as those are tested in that library already.

Check out #2 as well, benchmarks are likely the more important piece, since folks will want to know how the lib performs in terms of speed and memory 👍

ChrisPenner avatar Oct 03 '20 17:10 ChrisPenner