Standardize spelling of favorite/favourite

[mveytsman]

anacaonda.Tweet has a field called FavoriteCount while anaconda.User has a field called FavouritesCount.

It would be nice is the library used the same spelling for both fields. For what it's worth, the twitter API seems to prefer the non-US "favourite".

[ChimeraCoder]

Man, this is really funny - I hadn't noticed!

The Favorite method is named after the /favorites/create endpoint (https://dev.twitter.com/rest/reference/post/favorites/create). Bizarrely, this method returns a JSON response containing a tweet with favourites_count, and in fact the endpoint name is the only place the spelling favorite appears on the entire page.

Our goal is to make this library match the Twitter API documentation as closely as possible, though they do seem to be inconsistent here with their own usage. Let me go through the codebase and make sure we're at least consistently matching the spelling that Twitter uses for the field and method names (it seems we aren't everywhere). After that perhaps we can add an alias to one of the spellings so people don't have to guess which is correct.

Thanks for pointing this out!