graphql-platform icon indicating copy to clipboard operation
graphql-platform copied to clipboard

Update NATS library

Open TechnoBerry opened this issue 1 year ago • 8 comments

Product

Hot Chocolate

Is your feature request related to a problem?

HotChocolate.Subscriptions.Nats based on the library that is no longer maintained: https://github.com/Cysharp/AlterNats

The solution you'd like

It would be good to migrate HotChocolate.Subscriptions.Nats to the official NATS client: https://github.com/nats-io/nats.net.v2

TechnoBerry avatar Jan 09 '24 18:01 TechnoBerry

Hey @TechnoBerry do you want to do a PR on this?

michaelstaib avatar Jan 10 '24 20:01 michaelstaib

@oising FYI. 🙂

glen-84 avatar Jan 17 '24 15:01 glen-84

@TechnoBerry I wouldn't update this just yet -- there's still a lot of churn going on with the 2.x NATS client, with breaking changes being introduced even with minor releases. I'd wait until 2.1 at least. They're on 2.1-preview3 at the moment.

While it's true that AlterNats is no longer being maintained (in fact, the NATS v2 client is a direct fork of AlterNats) - it is very stable.

/cc @michaelstaib

oising avatar Jan 18 '24 16:01 oising

A fair point. I think it really makes sense to wait for version 2.1.

TechnoBerry avatar Jan 18 '24 23:01 TechnoBerry

We are now on Version 2.3.2. Any chance of an update?

DDZ-DO avatar Jul 31 '24 16:07 DDZ-DO

@oising Do you think an upgrade makes sense in the meantime?

PascalSenn avatar Jul 31 '24 18:07 PascalSenn

@oising Do you think an upgrade makes sense in the meantime?

I think a migration to the official SDK is probably due. I believe the 2.x client has had enough time to mature. I'm curious though if this is a blocker for anyone on the thread?

oising avatar Jul 31 '24 19:07 oising

@TechnoBerry @DDZ-DO would either of you like to create a PR?

PascalSenn avatar Aug 01 '24 11:08 PascalSenn