ansible-collection-checkmk.general icon indicating copy to clipboard operation
ansible-collection-checkmk.general copied to clipboard

Implement module "site" for configuring distributed monitoring

Open lgetwan opened this issue 1 year ago • 5 comments

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

There was no module for managing distributed monitoring sites.

What is the new behavior?

Now there is.

Other information

Thanks to the usage of IDs in the site management REST API, it was possible to make this module idempotent. If you run into problems, please let us know.

lgetwan avatar Aug 20 '24 13:08 lgetwan

I also disliked the module name tbo, so I changed it to distmon, which is short and recognizable. Also removed Python Typing to make it Python2.7 compatible. Changelog was also added lately.

lgetwan avatar Aug 21 '24 07:08 lgetwan

Currently, the integration tests are not correct. I have to refine them. But from my point of view, the module itself is ready for some first manual tests.

lgetwan avatar Aug 27 '24 10:08 lgetwan

Looks like the integration tests runs into this problem: https://github.com/actions/runner-images/issues/6680 Probably, the tests take too long?

lgetwan avatar Aug 28 '24 06:08 lgetwan

Looks like the integration tests runs into this problem: actions/runner-images#6680 Probably, the tests take too long?

I'll investigate, but I doubt, it is a timeout issue, we have/had tests, which run longer. It might be resource exhaustion.

robin-checkmk avatar Aug 28 '24 08:08 robin-checkmk

It was indeed resource exhaustion. I reduced the number of remote sites to be created. Now github is happy.

lgetwan avatar Aug 28 '24 14:08 lgetwan

I tested the following without issues against 2.2.0p33cee:

  • Creating a site connection
  • Loging in to a site
  • Changing an attribute of a site connection
  • Logout from a site
  • Remove a site

Will discuss with my colleague as soon as he is back from vacation but I would say its working good. Thank you for all the effort spent.

mike1098 avatar Sep 30 '24 07:09 mike1098