ansible-collection-checkmk.general icon indicating copy to clipboard operation
ansible-collection-checkmk.general copied to clipboard

Feature agent windows support

Open muehlings opened this issue 3 years ago • 2 comments

Pull request type

  • [ ] Bugfix
  • [X] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the new behavior?

This is my contribution to PR #156

  • Changes in linux agent roles
  • Addition in windows agent roles
  • Preparation files for WinRM to work

muehlings avatar Nov 01 '22 11:11 muehlings

Sorry, but I have no idea how to change the behavior of github concerning these checks:

  1. Running sanity test "line-endings"
ERROR: Found 3 line-endings issue(s) which need to be resolved:
ERROR: preparation/ansible-winrm/00-ansible.cmd:0:0: use "\n" for line endings instead of "\r\n"

Line ending of \r\n is correct, because those are windows cmd files. I tried to set the line ending in .gitattributes to LF or CRLF but the check always fails.

  1. Running sanity test "pslint"
ERROR: Found 6 pslint issue(s) which need to be resolved:
ERROR: preparation/ansible-winrm/ConfigureRemotingForAnsible.ps1:281:58: PSCustomUseLiteralPath: Use the explicit -LiteralPath parameter name instead of -Path

This script is from ansible and I don't want to change anything in it.

I did change it in my branch anyway, but the sanity test does not use my version: https://github.com/muehlings/ansible-collection-tribe29.checkmk/commit/19e2590126967244db2c7b47c32a46cb04e56a5b

I would prefer to skip the tests on both types of files (.cmd and .ps1) at the moment.

muehlings avatar Nov 03 '22 09:11 muehlings

I agree, that we can ignore those tests right now. Let me review your changes and try to understand them, before we merge them.

robin-checkmk avatar Nov 04 '22 16:11 robin-checkmk