ansible-collection-checkmk.general icon indicating copy to clipboard operation
ansible-collection-checkmk.general copied to clipboard

Update feature host groups

Open msekania opened this issue 3 years ago • 3 comments

Changed host_group_name and host_groups with name and groups, respectively, also to match two other groups, service and contact.

Pull request type

  • [ ] Bugfix
  • [x] Feature
  • [x] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Currently user has to specify field host_group_name to create the host groups with the given value. Similarly user has to specify field host_groups with list of to be created host groups.

What is the new behavior?

  • host_group_name is changed with simple name
  • host_groups is changed with simple groups

Other information

msekania avatar Oct 28 '22 14:10 msekania

@robin-tribe29 what I see issues are with "Local download #183" branch and not with "Update feature host groups #185"!

msekania avatar Oct 29 '22 19:10 msekania

Still finishing some details, but this will merge rather soon. Will keep you posted.

robin-checkmk avatar Nov 11 '22 12:11 robin-checkmk

I will merge this after my vacation, I want to make sure to inform users properly about the breaking change.

robin-checkmk avatar Nov 18 '22 13:11 robin-checkmk

Hi @msekania! Sorry to keep you waiting here and even more apologies for the following: We discussed this change internally, and we came to the conclusion, that your idea of aliases makes a lot of sense. Can you tell, if it is a lot off effort to enable the old host_group_name and host_groups as additional aliases? That way, existing configuration does not break, while we can still go for the new naming and remove the old option names at a later time.

robin-checkmk avatar Dec 02 '22 13:12 robin-checkmk

Hi @robin-tribe29, I need to recall how I planned it, but latest by Monday I will have it ready.

msekania avatar Dec 02 '22 13:12 msekania

Awesome dude, thanks! :pray:

robin-checkmk avatar Dec 02 '22 13:12 robin-checkmk