ansible-collection-checkmk.general
ansible-collection-checkmk.general copied to clipboard
Update feature host groups
Changed host_group_name and host_groups with name and groups, respectively, also to match two other groups, service and contact.
Pull request type
- [ ] Bugfix
- [x] Feature
- [x] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [x] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
What is the current behavior?
Currently user has to specify field host_group_name to create the host groups with the given value.
Similarly user has to specify field host_groups with list of to be created host groups.
What is the new behavior?
host_group_nameis changed with simplenamehost_groupsis changed with simplegroups
Other information
@robin-tribe29 what I see issues are with "Local download #183" branch and not with "Update feature host groups #185"!
Still finishing some details, but this will merge rather soon. Will keep you posted.
I will merge this after my vacation, I want to make sure to inform users properly about the breaking change.
Hi @msekania! Sorry to keep you waiting here and even more apologies for the following:
We discussed this change internally, and we came to the conclusion, that your idea of aliases makes a lot of sense.
Can you tell, if it is a lot off effort to enable the old host_group_name and host_groups as additional aliases? That way, existing configuration does not break, while we can still go for the new naming and remove the old option names at a later time.
Hi @robin-tribe29, I need to recall how I planned it, but latest by Monday I will have it ready.
Awesome dude, thanks! :pray: