ansible-collection-checkmk.general icon indicating copy to clipboard operation
ansible-collection-checkmk.general copied to clipboard

Feature agent windows support

Open robin-checkmk opened this issue 3 years ago • 6 comments

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

There is no support for Windows clients in the agent role.

What is the new behavior?

We want to introduce Windows support for the agent role.

Other information

Currently, there are no resources to start developing this. If you have the time and possibilities, have at it. :slightly_smiling_face: There are files from another project here, but you should be able to get started from the existing tasks for Linux. If you have questions, feel free to drop them here.

robin-checkmk avatar Sep 21 '22 15:09 robin-checkmk

I can help with testing later. I have setup almost all current and some older Windows operating systems (Win 10/11, Server 2012 up to Server 2022). I'm sure there are some preparation steps before ansible can manage a windows host.

muehlings avatar Oct 10 '22 12:10 muehlings

The preparation of Windows hosts is working in my lab. The tasks and vars of my playbook and inventory are working, but I had to split and reorganize the Linux parts. Now I have the problem how I PR this PR or should I use my own branch and make a new PR?

muehlings avatar Oct 14 '22 12:10 muehlings

That sounds great! Did you fork this feature branch, or did you fork devel? Anyway, just open a new PR, and we will take it from there.

robin-checkmk avatar Oct 14 '22 13:10 robin-checkmk

I forked from tribe29/ansible-collection-tribe29.checkmk:feature-agent-windows-support for the initial Windows files.

I am absent for the next two weeks, but you can already test with https://github.com/muehlings/ansible-collection-tribe29.checkmk/tree/feature-agent-windows-support

New directory "preparation" is for getting winrm to work.

Other changes are in the agent role.

muehlings avatar Oct 14 '22 16:10 muehlings

Hello @robin-tribe29,

can you merge the two PRs into one?

Greetings

muehlings avatar Nov 03 '22 07:11 muehlings

@muehlings you mean #187? I would want to see the tests green, then there is probably no harm in merging into this feature branch.

Sorry, we are totally swamped, hence the silence in the project. Hopefully I can work on all this again within two weeks.

robin-checkmk avatar Nov 03 '22 07:11 robin-checkmk

Quick update: This is still in the making, but I am uncertain how to move forward, as I want the role re-structuration to be as solid as possible. So for the time being, any and every feedback on the state of this branch is welcome. I will try to work our some testing to make sure we do not break the role and that we have enough resources to quickly fix issues, if they occur.

robin-checkmk avatar Dec 20 '22 11:12 robin-checkmk

I can test, too, if necessary. I am very interested in that feature.

HaZet1968 avatar Jan 03 '23 13:01 HaZet1968

@muehlings I rebased this PR on top of the main branch and gave the role some love and clean up. Please check, if I broke something for you.

I am still not perfectly sure, when and how we will merge this for a release, but I did not forget about this, rest assured. :v:

robin-checkmk avatar Jan 16 '23 17:01 robin-checkmk

This pull request has been stale for 60 days. It will close in 7 days.

github-actions[bot] avatar Mar 18 '23 03:03 github-actions[bot]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Jun 23 '23 09:06 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

muehlings avatar Jun 23 '23 09:06 muehlings

I tested the proposed changes against the Linux side of things and cannot find a regression there. So I can greenlight the changes from that site.

However, anyone reading along, please do test this pull request and provide feedback, if you can.

If nothing comes up, @Max-checkmk will finalize work on this PR and we will merge and release it.

robin-checkmk avatar Aug 03 '23 09:08 robin-checkmk