Sema Checherinda
Sema Checherinda
Without tests it wont be merged. Please try to do them. It is better to check your good ideas with some tests than on real clusters. Usually IP is not...
> > Also, can you please add tests emulating the situation that will raise the new behaviour? > > Did not managed to write good test. Result of fix can...
> > > > Also, can you please add tests emulating the situation that will raise the new behaviour? > > > > > > > > > Did not...
In order to write tests I added new counter. I suppose that counter `AddressesBanned` would be useful to see how many addresses is banned in real workflow. So, lets switch...
CI: The specified key does not exist https://github.com/ClickHouse/ClickHouse/issues/63794 memory leak in openssl https://github.com/ClickHouse/ClickHouse/issues/63792 Other failed several tests seem to be flaky and they are not related to the changes.
@ianton-ru can you please adjust style? https://s3.amazonaws.com/clickhouse-test-reports/0/a24f141619626cb8a0369fffffa68dad5a530d76/style_check/black_output.txt
> @CheSema Is any chance to backport to 24.3 LTS? This is new feature. Normally we do not back port such changes. I will check if there are conflicts.
This commit breaks the Stateless tests! Look at this: https://s3.amazonaws.com/clickhouse-test-reports/61047/07e746d5a4ef7f858872a622d4e13b38ac24133a/stateless_tests__aarch64_.html Sigsev has happen in libunwind, all the program stopped by gdb. Gdb collected the traces and after that program just...
Integration tests have failed: for example test_config_yaml_main: ``` 2024.06.14 13:57:16.139897 [ 1 ] {} Application: Poco::Exception. Code: 1000, e.code() = 0, SSL context exception: Error loading private key from file...
Something wrong with `02922_deduplication_with_zero_copy`, I think it was fixed here https://github.com/ClickHouse/ClickHouse/issues/65486