Christian Hartmann

Results 243 comments of Christian Hartmann

> Only the codecov actions fails... see the PR for updating it... But the error here is just an invalid token. I experimented with the token yesterday. Perhaps we just...

One more thing: Do you really want to move closed/expired forms into a separate area in the App Navigation? I think this is not necessary as we already have the...

Yes I understand that and agree that after a while they will be less important. But for that one can archive the form. So I'd be happier without this grouping...

One more comment: the `state` is not imported in `FormsMigrator.php`. The linked file related props are also missing, but I'm not sure if they really make sense when you import...

Please integrate the fix for #1991 into this PR. Should be easy to fix and you can directly address the new state prop as well :)

> * The layout of the left navigation is a bit off, lot of whitespace (e.g. below the "Your forms" heading) and the entries are too big. Since there is...

@matthijskooijman did you already find some time to check susnux's comment?

No answer for quite some time, closing for now. Please feel free to re-open, after providing us with the needed info.

@susnux is anything like this already implemented in Text? I think we shouldn't add anything new but perhaps have some common base across the other apps. As a workaround, every...

> ``` > There was 1 error: > > 1) OCA\Forms\Tests\Unit\Controller\ApiControllerTest::testTransferOwner > OCP\AppFramework\OCS\OCSForbiddenException: This form is not owned by the current user > > /home/runner/work/forms/forms/apps/forms/lib/Controller/ApiController.php:386 > /home/runner/work/forms/forms/apps/forms/tests/Unit/Controller/ApiControllerTest.php:932 > ``` FormMapper...