Java-OCA-OCPP icon indicating copy to clipboard operation
Java-OCA-OCPP copied to clipboard

Backport to "maven artifacts" and result of "goJF"

Open in-fke opened this issue 3 years ago • 2 comments

  • Renamed Maven artifactId to better match the gradle equivalent.
  • Commented out the signing via maven-gpg-plugin (pom.xml)
  • Also checked in the results of "./gradlew goJF" (Java Formatting) (regular gradle build would fail due to formatting errors)

in-fke avatar Jan 25 '22 17:01 in-fke

Hi @in-fke,

First of all thanks for your contribution. I haven't accepted this one yet, as I don't know what the consequences of changing an artifacts name. Would people who use the lib via maven have to refer to a different artifact in their POM files?

Sincerely, Thomas

TVolden avatar Feb 26 '22 19:02 TVolden

Would people who use the lib via maven have to refer to a different artifact in their POM files?

Yes, if they want to upgrade to a newer version. I you change things you will not break things for others automatically since their are still referencing the old identifier. You should raise the version and adjust the artifactId at the same time. See how the artifacts are currently available: https://search.maven.org/search?q=g:eu.chargetime.ocpp e.g. https://search.maven.org/artifact/eu.chargetime.ocpp/v1_6/1.0.1/jar Changing it in your pom.xml / gradle the people who use it need to adjust accordingly. <grouId>:<artifactId>:<version> is a distinct artifact identifier globally.

in-fke avatar Mar 08 '22 15:03 in-fke