chainlit icon indicating copy to clipboard operation
chainlit copied to clipboard

Poetry lockfile should not be ignored

Open dokterbob opened this issue 1 year ago • 1 comments
trafficstars

For some reason, both poetry lock files are not committed to the repo.

This causes unpredictable builds and is explicitly against best practices, see: https://python-poetry.org/docs/basic-usage/#committing-your-poetrylock-file-to-version-control

Note also: "If you do not want to give up the reproducibility and performance benefits, consider a regular refresh of poetry.lock to stay up-to-date and reduce the risk of sudden breakage for users."

As a bonus, this will also make poetry install run way faster.

Specifically, the following should be removed from .gitignore:

  • poetry.lock

Possibly related: #1189

dokterbob avatar Aug 07 '24 14:08 dokterbob