ember-osf-web
ember-osf-web copied to clipboard
Published
20 hours ago •
CenterForOpenScience
CenterForOpenScience
[ENG-6835] [ENG-8060] [ENG-8289] VRL Project PR - FE
Purpose
Verified Resource Linking - FE Part
Summary of Changes
VRL
- Update ember data to supported linked services, a new type of add-on
LINK - Added new linked services page to the Ember project page which lists a project's linked services includes icon, name, resource type and the link.
- In addition: edit button shows up if user has the right permission for user to reconfigure or remove the add-on
- Legacy project page: new "Linked Services" link in top nav bar which redirects to this page when clicked
- New work flow for configure linked services add-on for project, with Dataverse as current implementation
- New work flow for connect linked services account for user settings, with Dataverse as current implementation
- Unit tests fixes + mirage update
- [ ] Optional: new unit tests and more mirage update
For details, see mock-ups and/or try it on https://staging.osf.io/
Bonus (i.e. affects all add-ons)
- Allow finer-grained routing options within the project's add-ons page
- Don't created configured add-on pre-maturely
Screenshot(s)
N/A
Side Effects
N/A
QA Notes
N/A
Pull Request Test Coverage Report for Build 16118219201
Details
- 40 of 112 (35.71%) changed or added relevant lines in 16 files are covered.
- 3 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.2%) to 67.207%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| app/guid-node/links/controller.ts | 0 | 1 | 0.0% |
| app/models/configured-addon.ts | 0 | 1 | 0.0% |
| lib/osf-components/addon/components/addons-service/file-manager/component.ts | 0 | 1 | 0.0% |
| app/models/configured-citation-addon.ts | 0 | 2 | 0.0% |
| app/helpers/instance-of.ts | 5 | 8 | 62.5% |
| lib/osf-components/addon/components/addons-service/terms-of-service/component.ts | 0 | 3 | 0.0% |
| app/guid-node/links/route.ts | 0 | 5 | 0.0% |
| app/models/authorized-link-account.ts | 0 | 6 | 0.0% |
| lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts | 20 | 26 | 76.92% |
| app/models/configured-link-addon.ts | 0 | 10 | 0.0% |
| <!-- | Total: | 40 | 112 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| lib/osf-components/addon/components/addons-service/manager/component.ts | 3 | 54.65% |
| <!-- | Total: | 3 |
| Totals | |
|---|---|
| Change from base Build 15688718112: | -0.2% |
| Covered Lines: | 8536 |
| Relevant Lines: | 12231 |
