windows-registry-node Switch to -W versions of registry API

Switch to -W versions of registry API

Open RupW opened this issue 7 years ago • 4 comments

trafficstars

using UTF-16 strings throughout, to fix encoding issues in the key paths and value strings read and written.

This is my attempt to fix issue #44. For the wide strings I chose not to use the ref-wchar package since it uses iconv - which seems overkill for UTF-8 to UTF-16 conversion - and because it doesn't give us a mechanism to create a UTF-16 string either. We need this when preparing a buffer for RegSetValueEx, so I'd then either have to duplicate the iconv setup that ref-wchar does or just use Buffer.from(..., 'utf16le') anyway. So I've added a simple implementation reg-LPWSTR that uses Buffer's utf16le for the string conversion. It's possible that this won't work with characters outside the unicode BMP, and that's the reason that ref-wchar used iconv: I haven't tested that.

It passes your test suite, and some simple manual tests with non-Latin-1 characters.