Stefano Gottardo
Stefano Gottardo
PR can be reviewed, ~i have some problems in testings due to kodi crashes not related to this (amd problem #25985) that prevent me to make some tests e.g. DVD~...
i created a mkv with same languages/flags i used your settings  despite its weird that your mkv have forced and captions combined toghether to me the japanese track is...
i have found an iptv stream with embedded subtitiles, so i tested by myself this use case with iptv simple PVR addon, subs are selected as expected i was not...
some test builds for the review http://mirrors.kodi.tv/test-builds/android/arm/kodi-20241127-5c7cda41-fix_sub_selection-armeabi-v7a.apk http://mirrors.kodi.tv/test-builds/android/arm64-v8a/kodi-20241127-5c7cda41-fix_sub_selection-arm64-v8a.apk http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20241127-5c7cda41-fix_sub_selection-x64.exe http://mirrors.kodi.tv/test-builds/osx/x86_64/kodi-20241128-5c7cda41-fix_sub_selection-36419-x86_64.dmg http://mirrors.kodi.tv/test-builds/osx/arm64/kodi-20241128-5c7cda41-fix_sub_selection-6676-arm64.dmg
@garbear are you able to review this one? i would like to merge within this month to get possible user feedbacks
> 1. if you set "original", kodi select and show the "forced" track based on audio language > Can you explain this fix? yes, you can set the desired audio...
> Could be for the selection of forced/normal subs? Subs off by default > prioritize forced subs. Subs on > prioritize non-forced subs. Non-forced subs normally include the content of...
changes done, also implemented changes to fix last bug found above https://github.com/xbmc/xbmc/pull/25813#issuecomment-2530779646 updated pr description
you completely misunderstood the description mentioned kodi has, never, implemented support for “default” flags in subtitles this PR has no influence in that, and it is not the intention of...
if you have a particular use case that now seems not to be working, open an issue so that we can understand better the situation and investigate appropriately. if you...