carto-react icon indicating copy to clipboard operation
carto-react copied to clipboard

Fix Storybook showing args instead of properties

Open sclebal opened this issue 4 years ago • 4 comments

Story details: https://app.shortcut.com/cartoteam/story/147101

Using docs.code.type dynamic and jsx options it's possible to get dynamic source code.

Also, I've made a little clean to avoid undefined values and inconsistencies in stories.

sclebal avatar Sep 22 '21 15:09 sclebal

Pull Request Test Coverage Report for Build 1740264980

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.415%

Totals Coverage Status
Change from base Build 1740086684: 0.0%
Covered Lines: 1155
Relevant Lines: 1544

💛 - Coveralls

coveralls avatar Sep 22 '21 15:09 coveralls

The approach looks nice, but there are some pending stuff here. I think it needs a pretty detailed QA to find all

For example: Note: Always left (current / prod) vs right (local / this PR)

  • FormulaWidgetUI --> inline function is ignored) image

  • Palette --> not using theme, but hardcoded values image

VictorVelarde avatar Oct 19 '21 17:10 VictorVelarde

@borja-munoz putting this on-hold in the meantime

VictorVelarde avatar Oct 19 '21 17:10 VictorVelarde