carto-react
carto-react copied to clipboard
Fix Storybook showing args instead of properties
Story details: https://app.shortcut.com/cartoteam/story/147101
Using docs.code.type dynamic and jsx options it's possible to get dynamic source code.
Also, I've made a little clean to avoid undefined values and inconsistencies in stories.
This pull request has been linked to Shortcut Story #147101: Storybook shows args instead of properties.
Pull Request Test Coverage Report for Build 1740264980
- 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 70.415%
| Totals | |
|---|---|
| Change from base Build 1740086684: | 0.0% |
| Covered Lines: | 1155 |
| Relevant Lines: | 1544 |
💛 - Coveralls
The approach looks nice, but there are some pending stuff here. I think it needs a pretty detailed QA to find all
For example: Note: Always left (current / prod) vs right (local / this PR)
-
FormulaWidgetUI --> inline function is ignored)

-
Palette --> not using theme, but hardcoded values

@borja-munoz putting this on-hold in the meantime