analytics-toolbox-core icon indicating copy to clipboard operation
analytics-toolbox-core copied to clipboard

Published 20 hours ago • verified publisher icon CartoDB

chore(sf|quadbin): rewrite all quadbin functions from js to sql

Open luipir opened this issue 2 years ago • 4 comments
trafficstars

Description

Shortcut

  • Story: https://app.shortcut.com/cartoteam/story/320183
  • Autolink: [sc-320183]

port all possible JS code to SQL

Type of change

  • Refactor

Acceptance

Please describe how to validate the feature or fix

  1. all old unit test (and new one) have to pass

Basic checklist

  • Good PR name
  • Shortcut link
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

luipir avatar Jun 15 '23 11:06 luipir

This pull request has been linked to Shortcut Story #320183: Rewrite all quadbin functions from JS to SQL in Snowflake.

shortcut-integration[bot] avatar Jun 15 '23 11:06 shortcut-integration[bot]

creating the CTE as temporary table solve the issue (with almost similar execution time at elast for BBOX) but we loose the use of UDF and need to use procedures.

no idea if it is necessary to continue or assume the ticket blocked waiting for SF fixes of different strategies.

luipir avatar Jun 26 '23 13:06 luipir

Superseded by https://github.com/CartoDB/analytics-toolbox-core/pull/423

Jesus89 avatar Jul 11 '23 13:07 Jesus89

sorry closed too early... effectively all this JS function are not jet available in https://github.com/CartoDB/analytics-toolbox-core/pull/423

luipir avatar Jul 11 '23 15:07 luipir