dcx-react-library
dcx-react-library copied to clipboard
Feature/251 paginator
There are 0 events currently in the component please can you implement one as it is a requirement. I think all it needs to pass in is the current page "onPageChange={page => setCurrentPage(page)}" - from the ticket https://github.com/Capgemini/dcx-react-library/blob/ca23a92b3f1269598f5ca64770c47a514cb30d19/src/button/Button.tsx#L14
@Ali-Jahankah Please can you add an event as requested previously. If I am using the pagniator component currently there is no way of me knowing what page it's on. It needs a property called onClick or onPageChange where a user can pass in a function which is then called every time the page changes.
@Ali-Jahankah please can you make sure test coverage is at 100%
After that please merge the changes from release/1.1.0 into your branch and solve the merge conflicts
@Ali-Jahankah Comments from Daniele:
- The section element can be removed
- Please can you give a bit more information on the property descriptions, such as onPageChange what does it return?
- Line 90 page and index inside the map can you please give them types
- In the helper function please can you change 5 to be a property the user passes in?
Can you please also make the paginator in the example folder look similar to some of the examples in storybook where you have applied some css
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
064a290) to head (8533dd8). Report is 14 commits behind head on release/1.1.0.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## release/1.1.0 #687 +/- ##
===============================================
Coverage 100.00% 100.00%
===============================================
Files 85 88 +3
Lines 1553 1649 +96
Branches 539 579 +40
===============================================
+ Hits 1553 1649 +96
| Flag | Coverage Δ | |
|---|---|---|
100.00% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.