OpenRGB icon indicating copy to clipboard operation
OpenRGB copied to clipboard

Draft: Color picker cursor not restricted to bounds

Open 418Cat opened this issue 2 years ago • 3 comments

When picking a color in the Devices tab, the mouse cursor doesn't need to be strictly in the rectangle and circle bounds anymore.

It can be useful to pick edge colors or to pick a hue in the color circle without having to follow strictly the bounds. A small QOL improvement

418Cat avatar Sep 23 '23 18:09 418Cat

ColorWheel originally came from this project:

https://github.com/liuyanghejerry/Qt-Plus

I'm not fond of changing dependencies without updating the upstream, but since this hasn't been updated in 10 years maybe it's OK. I would still probably submit a PR against that repo to give upstream the chance to take the fix.

CalcProgrammer1 avatar Oct 11 '23 17:10 CalcProgrammer1

Will do, I'll open a pr for that repo to hopefully get it merged

418Cat avatar Oct 14 '23 08:10 418Cat

It seems like my pr on the Qt-Plus repo isn't really about to get pushed after more than 2 months. I don't know if there's gonna be updates on this particular dependency other than upstream

418Cat avatar Dec 28 '23 14:12 418Cat