lithium-fabric icon indicating copy to clipboard operation
lithium-fabric copied to clipboard

Remove the `SINE_TABLE` array in `MathHelper`

Open altrisi opened this issue 3 years ago • 1 comments
trafficstars

Lithium replaces the sin and cos methods in MathHelper, the only two places that access its SINE_TABLE array. That means that the array is unused after that, however it is still kept in memory.

Suggestion to remove it or at least make it an empty array.

altrisi avatar Jul 28 '22 20:07 altrisi

This might cause issues with mods that directly access the field, but I think it is unlikely that any mod does this.

It should be fine to do this

2No2Name avatar Jul 28 '22 20:07 2No2Name