cadquery icon indicating copy to clipboard operation
cadquery copied to clipboard

Update Wire fillet docstring

Open lorenzncode opened this issue 1 year ago • 2 comments

PR #1549 added fillet with docstring that says "Currently only open wires are supported". PR #1573 added support for closed wires but the docstring was not update.

There is also corruption of the Sphinx doc summary:

Screenshot from 2024-07-14 19-54-43

lorenzncode avatar Jul 15 '24 00:07 lorenzncode

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.92%. Comparing base (edabe5e) to head (d2c324c). Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1630   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files          28       28           
  Lines        6263     6263           
  Branches     1271     1271           
=======================================
  Hits         5945     5945           
  Misses        192      192           
  Partials      126      126           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 15 '24 01:07 codecov[bot]

I noticed some corruption in the Sphinx docs for new Workplane special methods. It's important to add empty line separating the field list in the docstring.

image

lorenzncode avatar Jul 15 '24 01:07 lorenzncode

Looks good @lorenzncode , I'll just go ahead and merge this. Thanks!

adam-urbanczyk avatar Sep 06 '24 17:09 adam-urbanczyk