CQ-editor icon indicating copy to clipboard operation
CQ-editor copied to clipboard

Disable Toggle Comment when Editor is not visible

Open lorenzncode opened this issue 6 months ago • 2 comments

There is a new Toggle Comment item under the Edit menu and shortcut key. I'd suggest to disable the feature when the Editor widget is not visible for users of external editors.

lorenzncode avatar Jun 02 '25 23:06 lorenzncode

@lorenzncode Is there a functional reason to do this (i.e. it causes a problem), or is it more of a user experience reason (i e. It causes confusion)?

jmwright avatar Jun 03 '25 01:06 jmwright

@jmwright It's more for user experience (nothing major). Since I'm not using the editor I'd prefer only the viewer options to be presented or enabled. Then I can safely ignore editor features and no chance I might comment something out that is not visible. I guess it would only comment line 1 if I were to trigger it accidentally.

lorenzncode avatar Jun 03 '25 01:06 lorenzncode

@lorenzncode This UX update was added in #529

jmwright avatar Aug 19 '25 17:08 jmwright

Thanks @jmwright ! In my case I don't toggle the Editor visibility. The Editor visibility is always off based on my existing preferences. I pass in the Python input file from CLI.

lorenzncode avatar Aug 20 '25 02:08 lorenzncode