CQ-editor icon indicating copy to clipboard operation
CQ-editor copied to clipboard

macOS build configuration for pyinstaller with associated helper assets

Open michaelgale opened this issue 5 years ago • 7 comments

New macOS platform specific assets and configuration are contained in a new folder "macos". The PyInstaller.spec file was accidentally reformatted with "black"--don't panic, despite the sea of red diff's only a handful of changes were made: i) new app=BUNDLE section at the end and ii) additional platform check at the beginning for the oce library path.

michaelgale avatar Jan 09 '20 15:01 michaelgale

Codecov Report

Merging #111 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage    86.5%   86.48%   -0.03%     
==========================================
  Files          16       16              
  Lines        1223     1221       -2     
  Branches      138      138              
==========================================
- Hits         1058     1056       -2     
  Misses        136      136              
  Partials       29       29
Impacted Files Coverage Δ
cq_editor/__main__.py 40% <ø> (-3.75%) :arrow_down:
cq_editor/main_window.py 93.91% <ø> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1cee3f4...01cc9f5. Read the comment docs.

codecov[bot] avatar Jan 09 '20 15:01 codecov[bot]

I give up. Either appveyor works and codecov fails or vice-versa. Too much time wasted for a simple commit.

michaelgale avatar Jan 09 '20 20:01 michaelgale

@michaelgale I sometimes ignore codecov if I think it's being too picky. I think your PR is fine. We can merge it even with codecov complaining.

jmwright avatar Jan 10 '20 03:01 jmwright

@jmwright Cool. To be honest, this is my first encounter with code coverage and I must say it was annoying! There is something psychologically annoying about the last red X due to a 0.03% difference in coverage!

FYI, I did check both building and running the macOS app bundle in macOS 10.14 Mojave and 10.15 Catalina and they both work.

One last Q: is there any value in adding a macOS CI auto build and test to the project?

michaelgale avatar Jan 10 '20 03:01 michaelgale

I think so, if it can be done without a large amount of effort. However, @adam-urbanczyk is the primary maintainer of this project. I'd want to make sure he's ok with it.

jmwright avatar Jan 10 '20 22:01 jmwright

@michaelgale thanks for all the work! Codecov is not a problem for merging this PR. I will have some review comments though.

I'd skip for now automatic building (can be always added later, but preferably as an azure pipeline). I'm trying to setup CI for Mac here: #101 - help will be welcome.

adam-urbanczyk avatar Jan 16 '20 20:01 adam-urbanczyk

In the meantime, I'll have a look at your CI build pipeline to see if I can help with the CI.

michaelgale avatar Jan 17 '20 21:01 michaelgale