AnythingSlider icon indicating copy to clipboard operation
AnythingSlider copied to clipboard

Convert plugin to use jQuery UI Widget Factory

Open ProLoser opened this issue 14 years ago • 4 comments
trafficstars

This isn't a critical issue, but I was in IRC and someone suggested that we update the plugin to utilize the ui widget factory.

I thought it may be worth looking into and considering if heavy development of this plugin continues. It would likely greatly reduce the footprint this plugin has (albeit creating a shared reliance on the related ui lib). It could also potentially clean up some of the work and code for us.

ProLoser avatar May 06 '11 21:05 ProLoser

I had another plugin that was based on the widget factory and I eventually had to make it independent of the widget factory because either I was doing something wrong or it broke when a newer version of jQuery UI came out. Honestly, I don't think it would "greatly" reduce the core footprint and we'd have less control over some aspects of the plugin.

I am not completely against it, but I don't have the time to attempt this conversion right now.

Mottie avatar May 07 '11 00:05 Mottie

I don't have any strong feelings either way on that. I guess I am not understanding any super major advantages to it. Can you explain a bit more how it "reduces the footprint" and cleans up stuff? I read through tho whole slideshow thing but I fear it just might be over my head.


Chris Coyier http://chriscoyier.net

On Fri, May 6, 2011 at 5:52 PM, ProLoser < [email protected]>wrote:

This isn't a critical issue, but I was in IRC and someone suggested that we update the plugin to utilize the ui widget factory.

I thought it may be worth looking into and considering if heavy development of this plugin continues. It would likely greatly reduce the footprint this plugin has (albeit creating a shared reliance on the related ui lib). It could also potentially clean up some of the work and code for us.

Reply to this email directly or view it on GitHub: https://github.com/ProLoser/AnythingSlider/issues/83

chriscoyier avatar May 07 '11 03:05 chriscoyier

Eh it was more food for thought than anything really. I was just putting it out there based on a recommendation from a regular on the irc channel. I actually didn't think it's necessarily worth it to convert. It just seems to be the direction they are pushing development in.

ProLoser avatar May 07 '11 11:05 ProLoser

That's cool. If you or anybody else involved with this wants to give it a crack, go for it. I would be interesting to see what the final code looks like. I'd say definitely do it as a "branch" --- that's what those are for right? =)


Chris Coyier http://chriscoyier.net

On Sat, May 7, 2011 at 7:24 AM, ProLoser < [email protected]>wrote:

Eh it was more food for thought than anything really. I was just putting it out there based on a recommendation from a regular on the irc channel. I actually didn't think it's necessarily worth it to convert. It just seems to be the direction they are pushing development in.

Reply to this email directly or view it on GitHub: https://github.com/ProLoser/AnythingSlider/issues/83#comment_1115177

chriscoyier avatar May 07 '11 12:05 chriscoyier