Connor 'Birb' McCormick

Results 7 comments of Connor 'Birb' McCormick

Thank you greatly for implementing #897 - Has been a lovely addition to my daily workflow, and am happy to now be a pledger for this project. Sorry to become...

Thanks for the quick update! From what I can see, this change successfully adds in support for Pug in .vue documents! And thank you for the suggestion of Indent Rainbow...

Re: Rainbow Bracket's indent guide, as I worry my example was confusing: Existing: ![image](https://user-images.githubusercontent.com/5267414/106813487-ed494000-66d5-11eb-8e23-db42052ce9ce.png) Desired: ![image](https://user-images.githubusercontent.com/5267414/106813575-0a7e0e80-66d6-11eb-9170-11129aac77a0.png)

Further notes about this quirk with instanceof available at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/instanceof#instanceof_and_multiple_context_e.g._frames_or_windows

A simple reproduction is available here - https://stackblitz.com/edit/vitejs-vite-tw7jyk?file=src%2FApp.vue This issue doesn't appear to be Nuxt-specific. The Pug template is passed as-is to compiler-dom, so the nodeTransforms are also being mis-applied...

Had another look at the above issue to see if anything's changed in newer versions. Excitingly it looks like the current version doesn't have the same issue with `

I'd struggled to think of an ideal fallback strategy with my previous PR too. Bit of a catch-22. Making the new method `default` has the lowest impact for existing implementations...