tket icon indicating copy to clipboard operation
tket copied to clipboard

Wasm encoding is not defined on the json schema

Open aborgna-q opened this issue 1 year ago • 2 comments

The wasm field in encoded operations does not appear in the schema. https://github.com/CQCL/tket/blob/develop/schemas/circuit_v1.json

As @johnchildren mentions in https://github.com/CQCL/tket-json-rs/issues/61#issuecomment-2258339939,

Honestly if they aren't too set on the schema yet there are some improvements I'd perhaps like to make such as renaming wasm_file_uid to uid

aborgna-q avatar Jul 30 '24 13:07 aborgna-q

Is this issue causing problems for tket-json-rs?

CalMacCQ avatar Sep 16 '24 10:09 CalMacCQ

We merged a definition that "looks to be alright" in https://github.com/CQCL/tket-json-rs/pull/61, but since the source of truth is deep in the cpp code there is no assurance that it is correct nor that it will remain correct.

A schema validation would probably fail too...

aborgna-q avatar Sep 25 '24 16:09 aborgna-q

This issue has been automatically marked as stale.

github-actions[bot] avatar Jan 24 '25 05:01 github-actions[bot]