guppylang icon indicating copy to clipboard operation
guppylang copied to clipboard

test: rfc: refactor: run_float_fn -> run_float_fn_approx

Open acl-cqc opened this issue 1 year ago • 1 comments

Generally one should not do exact floating-point comparisons anywhere, so maybe we should approx the default thing to do. If you really wanted an exact check you could pass abs=0.0, rel=0.0 I guess....

acl-cqc avatar Sep 18 '24 12:09 acl-cqc

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.67%. Comparing base (992b138) to head (fecff61).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          59       59           
  Lines        6138     6138           
=======================================
  Hits         5627     5627           
  Misses        511      511           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 18 '24 12:09 codecov-commenter