guppylang icon indicating copy to clipboard operation
guppylang copied to clipboard

hack: Add very basic debug info

Open mark-koch opened this issue 1 year ago • 2 comments

This branch is for testing of lowering of DWARF info in hugr-llvm. This implementation is quite hacky; we should wait until #257 is done to properly implement this.

This branch adds debug info to the following nodes:

  • Module (requires passing an explict file parameter when constructing a GuppyModule)
  • FuncDefn
  • Most ExtensionOps

mark-koch avatar Jul 26 '24 09:07 mark-koch

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Your title should look like this. The scope field is optional.

<type>(<scope>): <description>

If the PR includes a breaking change, mark it with an exclamation mark:

<type>!: <description>

and include a "BREAKING CHANGE:" footer in the body of the pull request.

Details:

Unknown release type "hack" found in pull request title "hack: Add very basic debug info". 

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - ci
 - chore
 - revert

hugrbot avatar Jul 26 '24 09:07 hugrbot

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.59%. Comparing base (6698b75) to head (a023228). Report is 5 commits behind head on main.

Files Patch % Lines
guppylang/hugr_builder/hugr.py 94.11% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   92.67%   92.59%   -0.08%     
==========================================
  Files          45       45              
  Lines        5105     5148      +43     
==========================================
+ Hits         4731     4767      +36     
- Misses        374      381       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 26 '24 09:07 codecov-commenter