guppylang
guppylang copied to clipboard
refactor!: Implement `result` using overloads instead of a custom node
Closes #1357
Depends on #1360
Note that this PR is only breaking for guppylang-internals
BREAKING CHANGE: Removed guppylang_internals.nodes.ResultExpr
BREAKING CHANGE: Moved guppylang_internals.std._internal.checker.{TAG_MAX_LEN, TooLongError} to guppylang_internals.std._internal.compiler.platform
Bencher Report
| Branch | feat/result-overload |
| Testbed | Linux |
Click to view all benchmark results
Codecov Report
:x: Patch coverage is 98.11321% with 2 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 93.52%. Comparing base (517dddf) to head (9fdeef3).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...ylang_internals/std/_internal/compiler/platform.py | 97.91% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## fix/comptime-args-call #1361 +/- ##
==========================================================
+ Coverage 93.50% 93.52% +0.01%
==========================================================
Files 125 126 +1
Lines 11282 11267 -15
==========================================================
- Hits 10549 10537 -12
+ Misses 733 730 -3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.