fix: Handle subscript borrows involving index coercions

[mark-koch]

Fixes #1356

[github-actions[bot]]

Bencher Report

Branch	fix/setitem-signature-check
Testbed	Linux

Click to view all benchmark results

Benchmark	Latency	Benchmark Result microseconds (µs) (Result Δ%)	Upper Boundary microseconds (µs) (Limit %)
tests/benchmarks/test_big_array.py::test_big_array_check	📈 view plot 🚷 view threshold	672,372.06 µs (-7.26%) Baseline: 725,034.48 µs	761,286.20 µs (88.32%)
tests/benchmarks/test_big_array.py::test_big_array_compile	📈 view plot 🚷 view threshold	1,556,216.88 µs (+1.90%) Baseline: 1,527,132.11 µs	1,603,488.71 µs (97.05%)
tests/benchmarks/test_big_array.py::test_big_array_executable	📈 view plot 🚷 view threshold	7,696,929.29 µs (+4.47%) Baseline: 7,367,755.62 µs	7,736,143.40 µs (99.49%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_check	📈 view plot 🚷 view threshold	50,683.99 µs (-32.87%) Baseline: 75,505.29 µs	79,280.55 µs (63.93%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile	📈 view plot 🚷 view threshold	88,770.55 µs (+1.33%) Baseline: 87,608.37 µs	91,988.79 µs (96.50%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_executable	📈 view plot 🚷 view threshold	599,721.38 µs (+0.71%) Baseline: 595,515.44 µs	625,291.21 µs (95.91%)
tests/benchmarks/test_prelude.py::test_import_guppy	📈 view plot 🚷 view threshold	49.19 µs (-0.23%) Baseline: 49.31 µs	51.77 µs (95.02%)

🐰 View full continuous benchmarking report in Bencher

[github-actions[bot]]

Bencher Report

Branch	fix/setitem-signature-check
Testbed	Linux

Click to view all benchmark results

Benchmark	hugr_bytes	Benchmark Result bytes x 1e3 (Result Δ%)	Upper Boundary bytes x 1e3 (Limit %)	hugr_nodes	Benchmark Result nodes (Result Δ%)	Upper Boundary nodes (Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile	📈 view plot 🚷 view threshold	143.67 x 1e3 (0.00%) Baseline: 143.67 x 1e3	145.10 x 1e3 (99.01%)	📈 view plot 🚷 view threshold	6,590.00 (0.00%) Baseline: 6,590.00	6,655.90 (99.01%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile	📈 view plot 🚷 view threshold	21.64 x 1e3 (0.00%) Baseline: 21.64 x 1e3	21.86 x 1e3 (99.01%)	📈 view plot 🚷 view threshold	606.00 (0.00%) Baseline: 606.00	612.06 (99.01%)

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 93.50%. Comparing base (cdc5c68) to head (51c5239).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1358   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files         125      125           
  Lines       11280    11280           
=======================================
  Hits        10547    10547           
  Misses        733      733           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.