Chris Bridge

Hi all, I am a highdicom developer who has worked extensively on the segmentation code. I have actually encountered this behaviour myself before also. Though unfortunately we never had time...

Does the issue only occur when there are multiple segments?

FYI [this method](https://github.com/herrmannlab/highdicom/blob/95f39dd722ae6d357af3f942e2130d0ff4d68bfc/src/highdicom/seg/sop.py#L2025) contains the logic that highdicom uses to reconstruct the segmentation mask for a list of source images when allowing for empty frames and multiple segments. It seems...

> I am wondering whether it should be a user warning or a warning level log message. I would probably favor the latter, because it may be nice to know...

Hi @malaterre, thanks a lot for reporting this issue. Unfortunately the Legacy Conversion part of the library has not got much love recently. There are known shortcomings and a long-standing...

Hi @seandoyle, I imagine when @hackermd wrote this he was being opinionated and wanted to force users to use values from a controlled terminology rather than free text, even though...

Implementing this in a backwards compatible way could get a bit messy. We'd probably need to create a new, alternative `TextQualitativeEvaluation`, or similar, and then accept `Sequence[Union[QualitativeEvaluation, TextQualitativeEvaluation]]` for the...

Hi @hackermd, sorry: I have only just noticed that this PR was waiting on my input... This is looking better and I think the behaviour for multiframe images makes sense,...

Hi @afshinmessiah , > Thank you @CPBridge for all your wonderful comments. You are most welcome. Thank you for working through them. I hope you were able to just click...

Hi @afshinmessiah thank you very much, after seeing your snippet I now understand the situation much better. @fedorov my primary concerns are: 1. Backwards compatibility of the LegacyConvertedXImage constructors, which...