Raphanus Lo

@coderabbitai review

Also, please follow the commit comment linting rules: https://github.com/longhorn/longhorn-manager/actions/runs/15556110001/job/43797125257?pr=3806

LGTM

Maybe we could add some annotation on engine image CR for uninstalling, just like what we did on backup target CR: https://github.com/longhorn/longhorn-manager/blob/a56819105fd965b73dbc70133e1eb5814d3bea91/controller/uninstall_controller.go#L811-L812

And there's a similar problem on LHN. ``` longhorn-manager-px25m longhorn-manager time="2025-06-17T10:01:49Z" level=warning msg="Rejected operation: Request (user: system:serviceaccount:longhorn-system:longhorn-uninstall-service-account, longhorn.io/v1bet a2, Kind=Node, namespace: longhorn-system, name: libvirt-ubuntu-k3s-worker1, operation: DELETE)" func="admission.(*Handler).admit" file="admission.go:106" error="could not...

Solution validated with patched longhorn manager (longhorn/longhorn-manager#3860 & longhorn/longhorn-manager#3861): to a cluster include an attached volume using a non-default engine image, the uninstallation job complete without any problem.

https://github.com/longhorn/longhorn-manager/blob/master/scheduler/replica_scheduler.go#L532 Maybe we could prioritize for localization rather than only consider the disk usage. WDYT? @shuo-wu @PhanLe1010 @c3y1huang @mantissahz @derekbit @innobead

Hi @sushant-suse, please help review this doc change, thanks.

Hi @sushant-suse , the reason and the steps of the workaround are updated. Please help review & reword it again, thanks.

We've added some instance protection in recent changes. Will update this PR.