CLI11 icon indicating copy to clipboard operation
CLI11 copied to clipboard

Add IWYU pragmas

Open gostefan opened this issue 1 year ago • 1 comments

Added include-what-you-use pragmas to:

  • let IWYU point users to the main include file CLI/CLI.hpp
  • tell IWYU that CLI/CLI.hpp is the main exporting header.

This should fix #816

gostefan avatar Feb 18 '24 17:02 gostefan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e4ee3af) to head (3e7e3e2). Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #1008    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           17        17            
  Lines         4546      4557    +11     
  Branches         0       971   +971     
==========================================
+ Hits          4546      4557    +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 18 '24 17:02 codecov[bot]

This looks OK to me. I am going to give @henryiii a few days to comment, then will merge.

phlptp avatar Feb 20 '24 14:02 phlptp

Oh, it is valid though to include individual headers (it's in the readme). It sounds like this will just point users to always including the conglomerate header? Shouldn't these (Config and formatter) have // IWYU pragma: keep instead?

henryiii avatar Feb 26 '24 15:02 henryiii

I looked through the Readme and didn't find any references to individually including headers except for the utilities (which I promptly forgot to correctly handle in my changes).

Is it ok to include the "regular" headers (e.g. Argv.hpp) individually? I'll adapt the PR accordingly.

gostefan avatar Feb 26 '24 21:02 gostefan