ipfixprobe icon indicating copy to clipboard operation
ipfixprobe copied to clipboard

Draft: Clang format - code reformatting

Open SiskaPavel opened this issue 2 years ago • 1 comments

Adds new options to the Makefile: Introduces new options, "format-check" and "format-fix," to the Makefile for checking and fixing code formatting in .cpp and .hpp files.

Performs code reformatting across the entire repository: Aims to achieve consistent and uniform code formatting by addressing code indentation, spacing, and other style-related issues in all relevant code files.

Incorporates a new step into the Continuous Integration (CI) process: Enhances code quality by adding the "make format-check" command to the CI pipeline, ensuring that code formatting is validated automatically for all code changes pushed to the repository. This step is crucial for maintaining code consistency and adherence to coding standards.

SiskaPavel avatar Oct 24 '23 10:10 SiskaPavel

Codecov Report

Attention: 2300 lines in your changes are missing coverage. Please review.

Comparison is base (cfc02c2) 41.26% compared to head (336c934) 41.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   41.26%   41.52%   +0.25%     
==========================================
  Files          94       94              
  Lines        8665     9152     +487     
  Branches     1299     1300       +1     
==========================================
+ Hits         3576     3800     +224     
- Misses       4321     4572     +251     
- Partials      768      780      +12     
Flag Coverage Δ
tests 41.52% <35.04%> (+0.25%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/ipfixprobe/input.hpp 100.00% <100.00%> (ø)
include/ipfixprobe/output.hpp 100.00% <100.00%> (ø)
process/http.cpp 44.12% <ø> (ø)
process/http.hpp 32.05% <ø> (+0.40%) :arrow_up:
process/icmp.cpp 28.57% <ø> (+1.90%) :arrow_up:
process/icmp.hpp 0.00% <ø> (ø)
process/idpcontent.cpp 96.15% <ø> (+0.32%) :arrow_up:
process/idpcontent.hpp 35.13% <ø> (+6.10%) :arrow_up:
process/md5.cpp 86.16% <ø> (ø)
process/mpls.cpp 30.76% <ø> (ø)
... and 76 more

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 24 '23 11:10 codecov-commenter