SSVC icon indicating copy to clipboard operation
SSVC copied to clipboard

Create an index of data files in the repository

Open ahouseholder opened this issue 9 months ago • 3 comments

          Can we add an index.json or index.md that lists all the files in each of these folders

data/json/ recursively ? I am happy to code this if we think it is needed.

Originally posted by @sei-vsarvepalli in https://github.com/CERTCC/SSVC/pull/727#pullrequestreview-2649177205

ahouseholder avatar Feb 28 '25 21:02 ahouseholder

Some of the files in the data/json folder are not quite correct for example https://github.com/CERTCC/SSVC/blob/main/data/json/decision_points/cvss/availability_impact_2_0_1.json

should be version 3.0.0 (There is NO Version 2.0.1 in the code)

https://github.com/CERTCC/SSVC/blob/2bea679ead3502b5a9a8435e01dcd10b47cfee04/src/ssvc/decision_points/cvss/availability_impact.py#L122

I think we are better off enumerating from the code to make sure things are matching up right.

sei-vsarvepalli avatar Feb 28 '25 23:02 sei-vsarvepalli

I am hoping enumerating this properly will get rid of this type of inconsistencies.

sei-vsarvepalli avatar Feb 28 '25 23:02 sei-vsarvepalli

Some of the files in the data/json folder are not quite correct for example https://github.com/CERTCC/SSVC/blob/main/data/json/decision_points/cvss/availability_impact_2_0_1.json

should be version 3.0.0 (There is NO Version 2.0.1 in the code)

SSVC/src/ssvc/decision_points/cvss/availability_impact.py

Line 122 in 2bea679 version="3.0.0",

I think we are better off enumerating from the code to make sure things are matching up right.

Should filenames like these be changed?

sei-renae avatar Mar 03 '25 12:03 sei-renae

I think with recent changes to autogenerate json examples via doctools.py and the addition of the registry object we've likely addressed the problems at the heart of this issue.

@sei-vsarvepalli can you please confirm?

ahouseholder avatar Sep 15 '25 16:09 ahouseholder

Yeh resolved. We can close this.

sei-vsarvepalli avatar Sep 15 '25 16:09 sei-vsarvepalli