libCEED
libCEED copied to clipboard
Shallow-water equations on the cubed-sphere miniapp
This is a WIP PR for the development of the shallow-water equations solver miniapp.
Note: This PR moves the fluids/navierstokes miniapp into the subdirectory fluids/navier-stokes/navierstokes (relative Makefile and .gitignore files already updated, as well as tests/junit.py and tests/tap.sh).
TODOs:
- [x] Finish development of Jacobian action part
- [ ] Debugging..................
- [x] Add good test/problem case(s) Edit: Added Advection of cosine bell, but the geostrophic problem case is not complete yet
- [x] Add
TESTARGStest run options for CI - [x] Add documentation in user-manual. Edit: Need to add description of different problem types
Codecov Report
Merging #550 into main will decrease coverage by
1.56%. The diff coverage isn/a.
@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 98.06% 96.50% -1.57%
==========================================
Files 250 234 -16
Lines 16077 15788 -289
==========================================
- Hits 15766 15236 -530
- Misses 311 552 +241
| Flag | Coverage Δ | |
|---|---|---|
| #backends | 96.26% <ø> (-1.40%) |
:arrow_down: |
| #examples | 76.54% <ø> (-10.00%) |
:arrow_down: |
| #gallery | 54.34% <ø> (-45.66%) |
:arrow_down: |
| #interface | 93.87% <ø> (-1.03%) |
:arrow_down: |
| #tests | 99.98% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| gallery/mass3d/ceed-mass3dbuild.h | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| gallery/poisson1d/ceed-poisson1dapply.h | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| gallery/poisson1d/ceed-poisson1dbuild.h | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| gallery/poisson3d/ceed-poisson3dapply.h | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| gallery/poisson3d/ceed-poisson3dbuild.h | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| gallery/poisson1d/ceed-poisson1dbuild.c | 15.38% <0.00%> (-84.62%) |
:arrow_down: |
| gallery/poisson3d/ceed-poisson3dbuild.c | 15.38% <0.00%> (-84.62%) |
:arrow_down: |
| gallery/mass3d/ceed-mass3dbuild.c | 16.66% <0.00%> (-83.34%) |
:arrow_down: |
| gallery/poisson1d/ceed-poisson1dapply.c | 18.18% <0.00%> (-81.82%) |
:arrow_down: |
| gallery/poisson3d/ceed-poisson3dapply.c | 18.18% <0.00%> (-81.82%) |
:arrow_down: |
| ... and 34 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update cb15575...8d9ad6f. Read the comment docs.
@LeilaGhaffari , @jedbrown , I don't know if anyone is planning to potentially continue this work. But I guess it is ok to close for now? (Can always be restored, if desired)
I think it's worth leaving this PR open so the branch is saved. It may be that a fresh effort would start from main and cherry-pick docs and code from this branch, rather than trying to rebase this branch or merge main into this branch.
FYSA, we have a new SciDAC to develop models for compound flooding. Our effort at present is using finite volume methods (and will express them using libCEED for GPU efficiency), but we would like to compare FE methods. It's on unstructured grids and our tests thus far are regional (rather than global), but I expect some of the work in this branch will be useful.