libCEED icon indicating copy to clipboard operation
libCEED copied to clipboard

Published 20 hours ago • verified publisher icon CEED

Added biharmonic example in libceed

Open aneeshs1729 opened this issue 7 months ago • 4 comments

Hello libCEED team

This PR is related to issue https://github.com/CEED/libCEED/issues/1795. I'm happy to iterate on this further and open to any feedback or suggestions you have. Let me know if there are any style, structural, or interface adjustments you'd like to see!

Thanks a lot for your time

aneeshs1729 avatar Apr 19 '25 03:04 aneeshs1729

This PR appears to be missing the corresponding hpp file with the QFunction source code like BP1 and BP3 have.

jeremylt avatar Apr 19 '25 03:04 jeremylt

Hi @aneeshs1729 , thank you for your contribution! Please address Jeremy's comment here. Thank you

valeriabarra avatar Apr 29 '25 17:04 valeriabarra

@aneeshs1729 , thank you for your work. Are you able to address the reviewer's comments?

valeriabarra avatar May 19 '25 22:05 valeriabarra

@aneeshs1729 , thank you for your work. Are you able to address the reviewer's comments?

Hello Professor barra, Yes, I am working on addressing those. Updates coming soon

aneeshs1729 avatar May 20 '25 18:05 aneeshs1729

Hi @aneeshs1729 , how are you? I was wondering if you intended to complete this PR or if there were any impeding issues that you encountered.

There are a couple of other potential contributors that are eyeing this project and I was wondering if there was a missing interface for which this BP could not be completed or if it was just for personal reasons. Thank you!

valeriabarra avatar Oct 10 '25 17:10 valeriabarra