CEC icon indicating copy to clipboard operation
CEC copied to clipboard

Corrections Needed in README and Type Hinting in Code

Open cmj2002 opened this issue 2 years ago • 1 comments

Thank you for your work on CEC. I'm very interested in your research because I'm currently doing similar work. I installed the environment according to your README and tried to run your code, and I found some issues in it.

First, The command to run the program in the README needs to be updated. The parameters passed in hydra should not include --. For example, python3 main/dmlab/train.py --method={METHOD} --task={TASK} --gpus={GPU} --data_path={DATA_PATH} should be changed to python3 main/dmlab/train.py method={METHOD} task={TASK} gpus={GPU} data_path={DATA_PATH}.

Secondly, it seems that you have used the wrong type hint, for example, you wrote list[float] instead of List[float], which will result in TypeError: 'type' object is not subscriptable. The same thing happens to Dict and Tuple.

I believe these issues might be bugs in the codebase. As such, I kindly request your assistance in addressing and rectifying these problems. After making these changes, please ensure to test the code thoroughly to prevent any further problems. Thank you.

cmj2002 avatar Oct 19 '23 15:10 cmj2002