talk-to-chatgpt icon indicating copy to clipboard operation
talk-to-chatgpt copied to clipboard

Sentence breaking doesn't work well with Turkish number format

Open cemreefe opened this issue 2 years ago • 2 comments

In Turkish, thousands are separated with a fullstop . and fractions are separated with a comma . as opposed to many other languages that use a comma , for thousands and . for fractions. See example:

English:

The expenses came up to 1,550,309.56 TRY.

Turkish:

Harcamalar 1.550.309,56 TL tuttu.

The sentence separation function below could be improved to take into account thse format differences.

https://github.com/C-Nedelcu/talk-to-chatgpt/blob/8865d3e957af4237fd9bb8d46a3089a8eba3c7d8/chrome-extension/content.js#L421-L455

cemreefe avatar May 25 '23 17:05 cemreefe

Thank you, this is true, numbers need to be correctly parsed.

C-Nedelcu avatar May 26 '23 01:05 C-Nedelcu

Hello, I would like to work on this, can it be assigned to me

abhisheksharma010 avatar Jul 11 '23 00:07 abhisheksharma010