libsip icon indicating copy to clipboard operation
libsip copied to clipboard

Project state and contributing

Open abhijeetbhagat opened this issue 4 years ago • 1 comments

Hi, thank you for creating this library! I would very much like to contribute to the project to help it reach future milestones.

I don’t see any issues though. What is the current status of this library?

abhijeetbhagat avatar Apr 14 '21 14:04 abhijeetbhagat

Hi Thanks for your interest.

This library is currently functioning but it could use a lot of readability improvements. I began working on a VCard parser rolodex to have a simpler protocol to work around with nom, I've just about finished with that library only a few more things to add. I planned to return to this library once i found the best way to rework the parser.

I would love contribution's, between family and work i never have enough time for my personal projects. Some of the improvements the parser needs

  • Use nom macro's instead of functions for readability
  • use &str instead of &[u8] as input type (This mostly helps with error reporting)
  • use VerboseError<&str> as error directly instead of using the ParseError trait.

Aside from the parser i would like this library to remain very simple only providing Reading/Writing and a few helpers for common use cases. I've only used this library as a client and the structures are included in the client module but adding a few more modules with helper structures for common use cases would be ideal.

patrickisgreene avatar Apr 15 '21 18:04 patrickisgreene