rust-csv icon indicating copy to clipboard operation
rust-csv copied to clipboard

Published 20 hours ago • verified publisher icon BurntSushi

refactor: make serde an optional dependency

Open anna-is-cute opened this issue 6 years ago • 8 comments
trafficstars

See title! Closes #126.

My concerns:

  1. Cargo.toml took a beating with required features.
  2. Doc comments with serde are ugly.

I think 2 is fine, but 1 feels awful.

anna-is-cute avatar Oct 09 '19 20:10 anna-is-cute

I think the rustfmt output looks much worse in this case, but I added a commit just for the sake of CI passing.

anna-is-cute avatar Oct 09 '19 20:10 anna-is-cute

I just tried you branch, removed all the [[xxx]] required-features = ["serde"] configurations lines and run tests and benches without having the compiler to complain. Do you think those are necessary?

Kerollmops avatar Oct 09 '19 20:10 Kerollmops

Running cargo test --no-default-features failed without it when I tried. Did you attempt that?

anna-is-cute avatar Oct 09 '19 20:10 anna-is-cute

Hum... You are right :) Just tried.

Kerollmops avatar Oct 09 '19 20:10 Kerollmops

What's the status of this PR? I would like this feature, so if there's anything I can do to get this merged let me know.

jbaum98 avatar Jul 19 '20 21:07 jbaum98

@BurntSushi Are there any plans to merge this PR?

devashishdxt avatar Feb 25 '21 07:02 devashishdxt

@BurntSushi Are there any plans to merge this PR?

Perhaps eventually.

BurntSushi avatar Feb 25 '21 08:02 BurntSushi

@BurntSushi Are there any plans to merge this PR?

Perhaps eventually.

Are there any changes required before merging this?

devashishdxt avatar Feb 25 '21 08:02 devashishdxt